<AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords

[Baesken, Matthias]

Hi Goetz, not a Reviewer  but looks good except this diff :


--- a/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java	Fri Jul 28 14:06:28 2017 +0200
+++ b/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java	Mon Aug 14 11:23:42 2017 +0200
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it


Seems to me an old copyright year info 2012,2013  appeared  for some reason .

Best regards, Matthias



-----Original Message-----
From: Lindenmaier, Goetz 
Sent: Montag, 14. August 2017 11:38
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Baesken, Matthias <matthias.baesken at sap.com>; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords

Hi,

I uploaded an incremental patch:
http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.02/diffs-incremental.patch

and removed the changes to 
test/javax/swing/JTextArea/8148555/JTextAreaEmojiTest.java
because that was in the meantime annotated as headful in the client repo.

Best regards,
  Goetz.

> -----Original Message-----
> From: awt-dev [mailto:awt-dev-bounces at openjdk.java.net] On Behalf Of
> Lindenmaier, Goetz
> Sent: Freitag, 11. August 2017 13:58
> To: Baesken, Matthias <matthias.baesken at sap.com>; awt-
> dev at openjdk.java.net
> Subject: Re: <AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add
> keywords
> 
> Hi Matthias,
> 
> 
> 
> thanks for looking at this change.
> 
> 
> 
> I fixed the copyrights, (I actually had a bug skipping 2015, --> 2015, 2017, in my
> script).
> 
> I also adapted the "summary" and double checked jtreg is parsing this
> correctly.
> 
> (I was not sure with the line break and # comments.)
> 
> 
> 
> The test test/java/awt/print/PrinterJob/Margins.java
> 
> Just opens a window "No printer found" and terminates as 'passed'
> 
> if the printer is missing. So I would prefer to skip the
> 
> 'printer' key from that test.
> 
> 
> 
> New webrev:
> 
> http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.02/
> 
> 
> 
> Best regards,
> 
>   Goetz.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> From: Baesken, Matthias
> Sent: Freitag, 11. August 2017 09:29
> To: awt-dev at openjdk.java.net; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>
> Subject: re : AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords
> 
> 
> 
> 
> 
> *  I added more headful tests that are only run on windows.  I also added
> 
> *  some @requires os=windows where obvious.
> 
> *  I would appreciate a review!
> 
> *  http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/
> <http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/>
> 
> 
> 
> 
> 
> Hi Götz, not a reviewer  but I noticed  a few  of the files need  Copyright  year
> update  , for example
> 
> 
> 
> test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> 
> 
> 
> test/java/awt/im/6396526/IMLookAndFeel.java
> 
> 
> 
> test/java/awt/print/PrinterJob/ExceptionTest.java
> 
> 
> 
> test/java/awt/print/PrinterJob/ImagePrinting/NullClipARGB.java
> 
> 
> 
> test/java/awt/print/PrinterJob/PrintTextPane.java
> 
> 
> 
> test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> 
> 
> 
> test/javax/swing/JInternalFrame/8075314/bug8075314.java
> 
> 
> 
> test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> 
> 
> 
> test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.jav
> a
> 
> 
> 
> test/javax/swing/text/html/Test4783068.java
> 
> 
> 
> 
> 
> 
> 
> Does that one need   tag  printer as well ?
> 
> 
> 
> test/java/awt/print/PrinterJob/Margins.java
> 
> 
> 
> 
> 
> This  test  got a  very  long line in the  "summary"  of the tagging section,
> maybe better use 2 lines :
> 
> 
> 
> test/javax/print/PrintSE/PrintSE.sh
> 
> 
> 
> 
> 
> Otherwise looks ok to me .
> 
> 
> 
> Best regards, Matthias