<AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

Shashidhara Veerabhadraiah shashidhara.veerabhadraiah at oracle.com
Thu Dec 7 10:12:45 UTC 2017


Hi Semyon,

The changes looks fine to me.

Thanks and regards,
Shashi

-----Original Message-----
From: Semyon Sadetsky 
Sent: Saturday, December 2, 2017 3:55 AM
To: awt-dev at openjdk.java.net
Subject: <AWT Dev> [10] Review Request 8177758: Regression in java.awt.FileDialog

Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8177758

webrev: http://cr.openjdk.java.net/~ssadetsky/8177758/webrev.00/

In 8075516 it was not taken into account that yet another global reference to the file dialog peer is created  inside the called AwtFileDialog::Show(), so there one more global reference that prevents file dialog to be collected by GC. In the fix the second reference is eliminated.

--Semyon



More information about the awt-dev mailing list