<AWT Dev> [10] JDK-8190515: java.awt.Desktop.moveToTrash(File) prompts on Windows 7 but not on Mac

[Philip Race]

I expect I must be misunderstanding something.
The bug seems to be saying we should eliminate  confirmation dialogs but 
the fix reads
like it does the opposite since it removes flag bits which suppress the 
dialogs :

-            fop.fFlags = FOF_ALLOWUNDO;
+            fop.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMATION | FOF_NOERRORUI;

Does not "NOCONFIRMATION" mean "no confirmation dialog" ?

The bug says "does not happen on windows 10". Maybe there was a windows 7 bug ?
So after this fix, what happens on windows 7 and 10 ? What versions was the fix tested on ?

-phil.



On 12/8/17, 5:40 PM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 05/12/2017 23:23, Shashidhara Veerabhadraiah wrote:
>> Hi All, Please review a fix for the below bug.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8190515
>>
>> Webrev: http://cr.openjdk.java.net/~sveerabhadra/8190515/webrev.00/
>>
>> Summary: The file delete operation generates pop up dialog in 
>> windows7 and not in other higher than windows 7 versions. To keep it 
>> consistent across the different flavors, any dialog UI is being 
>> suppressed.
>>
>> Thanks and regards,
>>
>> Shashi
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20171209/fe060b81/attachment.html>