<AWT Dev> [10] RFR 8193435: Remove pre-1.2 SecurityManager text from java.awt.Toolkit

Sean Mullan sean.mullan at oracle.com
Mon Dec 18 19:29:17 UTC 2017


This looks good to me. The JDK SecurityManager implementation of 
checkRead and checkConnect have both been changed to call 
checkPermission since JDK 1.2 so the fallback code is redundant.

--Sean

On 12/18/17 11:47 AM, Dmitry Markov wrote:
> Hello,
> 
> Could you review a fix for jdk10, please?
> 
>   bug: https://bugs.openjdk.java.net/browse/JDK-8193435
>   webrev: http://cr.openjdk.java.net/~dmarkov/8193435/webrev.00/
>   CSR: https://bugs.openjdk.java.net/browse/JDK-8193709
> 
> Problem description:
> Support for pre-JDK 1.2 SecurityManager was removed under JDK-8189750
> 
> Fix:
> Updated the description of java.awt.Toolkit.getImage(URL u) and 
> java.awt.Toolkit.createImage(URL u) to get rid of “pre-JDK 1.2 
> SecurityManager” text. Also removed corresponding fallback code from 
> SunToolkit.checkPermission() and the constructor of URLImageSource.
> 
> Thanks,
> Dmitry


More information about the awt-dev mailing list