<AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

[Ambarish Rapte]

Hi Manajit,

Please include the jtreg tag: @key headful  

& also include the bug id: 4009555 from the original test.

Regards,

Ambarish

 

From: Sergey Bylokhov 
Sent: Monday, February 13, 2017 11:02 PM
To: Manajit Halder
Cc: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-7119774: [macosx] test ComponentMousePositionTest sometimes fail on Mac

 

It looks fine it will be better to dispose the frame in the finally block after the catch. In this case you can call dispose only once.

 

 

Hi Sergey,

 

Thank you for the review comment. Please review the modified code.

http://cr.openjdk.java.net/~mhalder/7119774/webrev.01/

 

Regards,

Manajit

 

On 13-Feb-2017, at 7:20 pm, Sergey Bylokhov <HYPERLINK "mailto:sergey.bylokhov at oracle.com"sergey.bylokhov at oracle.com> wrote:

 

Hi, Manajit.

Just one comment, the frame should be disposed if the test fails.

 

 

Hi All,

 

Kindly review the fix for JDK9.

 

Bug: 

https://bugs.openjdk.java.net/browse/JDK-7119774

 

Webrev: 

http://cr.openjdk.java.net/~mhalder/7119774/webrev.00/

 

Issue: 

Test fails sometimes on the last stage because getMousePosition() was getting called before the mouseMove completes. 

 

Fix: 

Fixed the issue by adding a waitForIdle() call after the mouseMove.

Along with the fix the following changes were done:

                The test was cleaned up and moved from closed to open

                Removed applet code

                Manual test to automatic test

 

Regards,

Manajit

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170214/600bac96/attachment.html>