<AWT Dev> [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
Rahul Singh
rahul.d.singh at oracle.com
Wed Feb 15 13:05:45 UTC 2017
Hi,
The reason splash screen was not visible is, "-splash:test.png" was not
able to get the path of the image. I've modified
*"GenerateTestImage.java"* generating Image for
FullScreenAfterSplash.java. Now the image is generated in "scratch"
folder and "-splash:test.png" readily gets the image and splash screen
is visible now.
Bug:https://bugs.openjdk.java.net/browse/JDK-8140329
Webrev: http://cr.openjdk.java.net/~vagarwal/8140329/webrev_05/
-Regards,
Rahul Singh
On 2017-02-07 10:16 PM, Sergey Bylokhov wrote:
>
>> 7 февр. 2017 г., в 10:35, Rahul Singh <rahul.d.singh at oracle.com
>> <mailto:rahul.d.singh at oracle.com>> написал(а):
>>
>> Hi,
>>
>> I've made the required changes in the test. I've updated the position
>> of the cursor which is the way to reproduce the original bug
>> https://bugs.openjdk.java.net/browse/JDK-8024185.
>>
>> Bug:https://bugs.openjdk.java.net/browse/JDK-8140329
>> Webrev: http://cr.openjdk.java.net/~vagarwal/8140329/webrev_04/
>>
>> The splash screen is visible if I run without jtreg. Jtreg is taking
>> the file which was the main issue while fixing this bug.
>>
> Please confirm that the splash is visible when run with jtreg.
>>
>>
>> -Regards,
>> Rahul Singh
>>
>>
>> On 2017-01-16 9:23 PM, Sergey Bylokhov wrote:
>>> Hi, Rahul.
>>> I have run the test on the OS X 10.12 and it fail, because it tried
>>> to find a maximize button on the wrong place. In idk 10.9 it was on
>>> the right side and in 10.10 it is a small green button. It was filed
>>> as JDK-8051590 as a jdk bug, but actually the bug is in the test.
>>> Please update it to complete sucsessfully on all OS X versions.
>>>
>>> Also can you please double check that the generated splash screen is
>>> actually shown, the test uses «-splash:test.png» option which
>>> depends from the current folder.
>>>
>>>> Hi all,
>>>> Gentle reminder for review of
>>>>
>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8140329
>>>> Webrev:http://cr.openjdk.java.net/~vagarwal/8140329/webrev_03/
>>>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_03/>
>>>>
>>>> Regards,
>>>> Rahul Singh
>>>>
>>>>
>>>> On 2017-01-12 1:38 PM, Ambarish Rapte wrote:
>>>>> Hi Rahul,
>>>>> Fix looks good to me. +1
>>>>> Regards,
>>>>> Ambarish
>>>>> *From:*Rahul Singh
>>>>> *Sent:*Thursday, January 12, 2017 12:11 PM
>>>>> *To:*Ambarish Rapte;awt-dev at openjdk.java.net
>>>>> *Subject:*Re: <AWT Dev> [awt-dev] Request for Approval and Review:
>>>>> JDK-8140329 [TEST BUG]
>>>>> java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
>>>>>
>>>>> Hi Ambarish,
>>>>>
>>>>> omitted unused file GenerateTestImage.java from the patch.
>>>>> http://cr.openjdk.java.net/~vagarwal/8140329/webrev_03/
>>>>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_03/>
>>>>>
>>>>> -Regards,
>>>>> Rahul Singh
>>>>>
>>>>> On 2017-01-11 1:40 PM, Ambarish Rapte wrote:
>>>>>
>>>>> Hi Rahul,
>>>>> Fix looks good.
>>>>> But I think the file/GenerateTestImage.java/**should be
>>>>> omitted from patch as it does not have any fix related change*.*
>>>>> Regards,
>>>>> Ambarish
>>>>> *From:*Rahul Singh
>>>>> *Sent:*Friday, January 06, 2017 11:22 AM
>>>>> *To:*awt-dev at openjdk.java.net <mailto:awt-dev at openjdk.java.net>
>>>>> *Subject:*Re: <AWT Dev> [awt-dev] Request for Approval and
>>>>> Review: JDK-8140329 [TEST BUG]
>>>>> java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
>>>>>
>>>>> Hi all,
>>>>> The "user.dir" is saving the generated image in a common
>>>>> folder scratch whereas "test.classes" is saving it to a
>>>>> specific folder. Compiling the test file before running it is
>>>>> actually solving the problem.
>>>>>
>>>>> http://cr.openjdk.java.net/~vagarwal/8140329/webrev_02/
>>>>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_02/>
>>>>>
>>>>> Regards,
>>>>> Rahul Singh
>>>>>
>>>>> On 1/4/2017 5:32 PM, Rahul Singh wrote:
>>>>>
>>>>> Hi Ajit,
>>>>> Changes made
>>>>> http://cr.openjdk.java.net/~vagarwal/8140329/webrev_01/
>>>>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev_01/>
>>>>>
>>>>> Regards,
>>>>> Rahul Singh
>>>>>
>>>>> On 1/4/2017 10:38 AM, Ajit Ghaisas wrote:
>>>>>
>>>>> The fix looks good.
>>>>> I suggest to replace wildcard import statements with
>>>>> specific ones in both the files in webrev.
>>>>> Regards,
>>>>> Ajit
>>>>> *From:*Rahul Singh
>>>>> *Sent:*Tuesday, January 03, 2017 6:17 PM
>>>>> *To:*awt-dev at openjdk.java.net
>>>>> <mailto:awt-dev at openjdk.java.net>
>>>>> *Subject:*<AWT Dev> [awt-dev] Request for Approval and
>>>>> Review: JDK-8140329 [TEST BUG]
>>>>> java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
>>>>>
>>>>> Hi All,
>>>>>
>>>>>
>>>>>
>>>>> Please review the fix for the bug:JDK-8140329
>>>>> <https://bugs.openjdk.java.net/browse/JDK-7146533> [TEST BUG]
>>>>>
>>>>> The test java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java fails to create test.png in the given path by GenerateTestImage.java utility. I used "user.dir" to obtain the path.
>>>>>
>>>>>
>>>>>
>>>>> Bug Link:https://bugs.openjdk.java.net/browse/JDK-8140329
>>>>> <https://bugs.openjdk.java.net/browse/JDK-7146533>
>>>>>
>>>>>
>>>>>
>>>>> The webrev is :http://cr.openjdk.java.net/~vagarwal/8140329/webrev/
>>>>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev/>
>>>>>
>>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>>
>>>>>
>>>>> Rahul Singh
>>>>>
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170215/b25b6005/attachment-0001.html>
More information about the awt-dev
mailing list