<AWT Dev> [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java

Rahul Singh rahul.d.singh at oracle.com
Fri Jan 6 05:52:27 UTC 2017


Hi all,
The "user.dir" is saving the generated image in a common folder scratch 
whereas "test.classes" is saving it to a specific folder. Compiling the 
test file before running it is actually solving the problem.

  http://cr.openjdk.java.net/~vagarwal/8140329/webrev_02/

Regards,
Rahul Singh


On 1/4/2017 5:32 PM, Rahul Singh wrote:
>
> Hi Ajit,
> Changes made
> http://cr.openjdk.java.net/~vagarwal/8140329/webrev_01/
>
> Regards,
> Rahul Singh
>
>
> On 1/4/2017 10:38 AM, Ajit Ghaisas wrote:
>>
>> The fix looks good.
>>
>> I suggest to replace wildcard import statements with specific ones in 
>> both the files in webrev.
>>
>> Regards,
>>
>> Ajit
>>
>> *From:*Rahul Singh
>> *Sent:* Tuesday, January 03, 2017 6:17 PM
>> *To:* awt-dev at openjdk.java.net
>> *Subject:* <AWT Dev> [awt-dev] Request for Approval and Review: 
>> JDK-8140329 [TEST BUG] 
>> java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
>>
>> Hi All,
>> Please review the fix for the bug:JDK-8140329 <https://bugs.openjdk.java.net/browse/JDK-7146533>  [TEST BUG]
>> The test java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java fails to create test.png in the given path by GenerateTestImage.java utility. I used "user.dir" to obtain the path.
>> Bug Link:https://bugs.openjdk.java.net/browse/JDK-8140329 
>> <https://bugs.openjdk.java.net/browse/JDK-7146533>
>> The webrev is :http://cr.openjdk.java.net/~vagarwal/8140329/webrev/ 
>> <http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev/>
>> Regards,
>> Rahul Singh
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170106/65748d9f/attachment.html>


More information about the awt-dev mailing list