<AWT Dev> Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

[Ajit Ghaisas]

Fix looks fine.

 

Regards,

Ajit

 

From: Prasanta Sadhukhan 
Sent: Friday, January 06, 2017 2:46 PM
To: Prem Balakrishnan; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

 

looks ok to me.

Regards
Prasanta

On 1/6/2017 2:11 PM, Prem Balakrishnan wrote:

Hi Prasanta,

 

On Ubuntu 16.04 test is taking 21350ms instead of 20000ms.

Removed manual timeout and made test rely on jtreg timeout.

HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8172009/webrev.02/"http://cr.openjdk.java.net/~pkbalakr/8172009/webrev.02/

 

Regards,

Prem

 

From: Prasanta Sadhukhan 
Sent: Wednesday, January 04, 2017 4:36 PM
To: Ajit Ghaisas; Prem Balakrishnan; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: Re: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

 

And also, I think this test has nothing to do with "print". It should be moved to java/awt/Paint folder, I guess.

Do you have an idea why it is taking more than 20 secs to complete, which api is taking so much time? Is it on all platform, or some specific?

Regards
Prasanta

On 1/4/2017 4:20 PM, Ajit Ghaisas wrote:

Change looks fine.

 

Some correction can be done by replacing wildcard imports by specific imports.

 

Regards,

Ajit

 

 

From: Prem Balakrishnan 
Sent: Wednesday, January 04, 2017 4:09 PM
To: Ajit Ghaisas; Prasanta Sadhukhan; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

 

Hi,

Please review fix for JDK 9,

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8172009 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8172009/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/8172009/webrev.00/ 

 

Test  fails because it was taking more than 20 seconds to complete,  updated timeout  to 30 seconds.

 

Regards,

Prem

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170106/89d7a60a/attachment.html>