<AWT Dev> 9 RfR: JDK-818182: Broken link in javadoc for JSObject.getWindow

Mandy Chung mandy.chung at oracle.com
Thu Jun 15 18:09:35 UTC 2017


awt-dev would be a more appropriate mailing list to review this docs change.

As Lance suggests, you can use ${docRoot} instead since all modules in the docs bundle have the same docRoot.

You can fix it before your push.  No need to see the new patch.
 
Mandy

> On Jun 15, 2017, at 10:16 AM, Lance Andersen <lance.andersen at oracle.com> wrote:
> 
> 
>> On Jun 14, 2017, at 11:53 AM, Andy Herrick <andy.herrick at oracle.com> wrote:
>> 
>> Hello,
>> 
>> Please review simple change to fix broken link for:  JDK-818182 <https://bugs.openjdk.java.net/browse/JDK-8181821>: Broken link in javadoc for JSObject.getWindow
>>> diff -r 92d4889c9b57 src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
>>> --- a/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
>>> +++ b/src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java
>>> @@ -151,7 +151,7 @@
>>>     * JavaScript engine or if applet is {@code null}
>>>     *
>>>     * @deprecated  The Applet API is deprecated. See the
>>> -     * <a href="../../../../../../api/java/applet/package-summary.html">
>>> +     * <a href="../../java/applet/package-summary.html”>
> 
> I think this could be changed to:
> "{@docRoot}/java/applet/package-summary.html” 
> 
> I did something similar http://cr.openjdk.java.net/~lancea/8181832/webrev.01/ <http://cr.openjdk.java.net/~lancea/8181832/webrev.01/>
> 
> 
>>>     * java.applet package documentation</a> for further information.
>>>     */
>>> 
>> Thanks
>> /Andy
>> 
> 
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 



More information about the awt-dev mailing list