<AWT Dev> [10] Review Request: JDK-8159142 : Visible artifacts in sun/java2d/SunGraphics2D/DrawImageBilinear.java

[Sergey Bylokhov]

Hi, Pankaj.
D3DSurfaceData, XRSurfaceData and probably other SurfaceData use simple 
multiplication or ceil(). Should we update them also? and the test to 
catch the errors there as well.

On 30/10/2017 03:39, Pankaj Bansal wrote:
> Hi All,
> 
> Please review the fix for JDK 10.
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8159142
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~pbansal/8159142/webrev.00/
> 
> Issue:
> 
> The test runs with D3D and OpenGL both. The issue is with the OpenGL run 
> as there aee some visual artifacts in image when the HiDPI scale is set 
> to non-integer value like 2.5.
> 
> Fix:
> 
> The issue is due to precision error. In WGLSurfaceData.java, the width 
> and height is calculated by multiplying the width and height with scale. 
> But the ceil function was being used instead of round. It should be 
> using round as at most of the places, the round function is being used.
> 
> Also changed the test to run at uiScale of 2.5 to catch any further errors.
> 
> Regards,
> 
> Pankaj Bansal
> 


-- 
Best regards, Sergey.