<AWT Dev> [10] Review request for 8154405: AccessControlException by URLPermission check

[Sergey Bylokhov]

Looks fine.

On 17/11/2017 06:38, Dmitry Markov wrote:
> Hello,
> 
> Could you review a fix for jdk10, please?
> 
>   bug: https://bugs.openjdk.java.net/browse/JDK-8154405
>   webrev: http://cr.openjdk.java.net/~dmarkov/8154405/webrev.00/
> 
> Problem description:
> The current implementation of Toolkit.getImage(URL url) and 
> Toolkit.createImage(URL url) uses URLPermission to perform security 
> checks. However the documentation says that security manager’s method 
> checkPermission() is called with url.openConnection().getPermission() 
> permission and url.openConnection().getPermission() returns 
> SocketPermission. So there is an inconsistency between the documentation 
> and the implementation.
> 
> Fix:
> It is necessary to update the description of the methods to get rid of 
> confusing statements.
> 
> Thanks,
> Dmitry


-- 
Best regards, Sergey.