<AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails

[Manajit Halder]

Hi Ajit,

Modified the code as per your review comments.
Please review the changes.

http://cr.openjdk.java.net/~mhalder/8158366/webrev.01/ <http://cr.openjdk.java.net/~mhalder/8158366/webrev.01/>

Thanks,
Manajit

> On 27-Nov-2017, at 1:50 PM, Ajit Ghaisas <ajit.ghaisas at oracle.com> wrote:
> 
> 1) This test lacks copyright banner at the top
> 2) init() prints to System.err & returns silently in case of failure - suggest to capture failure and throw exception.
> 
> Regards,
> Ajit
> 
> -----Original Message-----
> From: Prem Balakrishnan 
> Sent: Monday, November 27, 2017 12:02 PM
> To: Sergey Bylokhov; Manajit Halder
> Cc: awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev> <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails
> 
> +1
> 
> Regards,
> Prem
> 
> -----Original Message-----
> From: Sergey Bylokhov 
> Sent: Friday, November 24, 2017 1:16 PM
> To: Manajit Halder <manajit.halder at oracle.com>; Prem Balakrishnan <prem.balakrishnan at oracle.com>
> Cc: awt-dev at openjdk.java.net
> Subject: Re: <AWT dev>[10] Review request for JDK-8158366: [macosx] Regression: closed/java/awt/dnd/RecognizedActionTest/RecognizedActionTest.html fails
> 
> Looks fine.
> 
> On 23/11/2017 02:05, Manajit Halder wrote:
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8158366
>> Webrev:
>> http://cr.openjdk.java.net/~mhalder/8158366/webrev.00/
> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20171127/9f6ac7fb/attachment-0001.html>