<AWT Dev> [10] Review Request: JDK-8159062 : [hidpi] DnD on Windows while scaling is non-integer

Pankaj Bansal pankaj.b.bansal at oracle.com
Tue Oct 24 09:43:33 UTC 2017


Hi All,

 

Please review the fix for JDK 10.

 

Bug:

https://bugs.openjdk.java.net/browse/JDK-8159062

 

Webrev:

 http://cr.openjdk.java.net/~psadhukhan/pankaj/JDK-8159062-webrev.00/

 

Issue:

There are issue with the mouse move events when HIDPI scale is set to some non-integer value like 1.25, 1.5, 2.5.

 

Fix:

The issue is due to precision error. In native side in the awt_Win32GraphicsDevice class,  ScaleUp and ScaleDown functions are used to get scaled value where ceil is used. But in java side, ClipRound is used which rounds the value instead of ceil. I think we should be doing round in native side also. This fixes the issue.

 

Regards,

Pankaj Bansal

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20171024/17f4a2c0/attachment.html>


More information about the awt-dev mailing list