<AWT Dev> [10] Review request for 8189204: Possible NPE in Component::getLocationOnScreen()

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Oct 26 00:52:00 UTC 2017


Looks fine.

On 25/10/2017 17:37, Semyon Sadetsky wrote:
> Hello,
> 
> Please review fix for JDK10:
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8189204
> 
> webrev: http://cr.openjdk.java.net/~ssadetsky/8189204/webrev.00/
> 
> The fix eliminates possibility of NPEs in Component 
> ::getLocationOnScreen().  Method Component 
> ::getLocationOnScreen_NoTreeLock() does not consistently scan the 
> component hierarchy because Component::getParent() may be overridden. 
> Also there are may be issues caused by peer field concurrent updates.
> 
> --Semyon
> 
> 
> 


-- 
Best regards, Sergey.


More information about the awt-dev mailing list