<AWT Dev> [10] Review Request: JDK-6857809 : [TEST_BUG] java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java

[Sergey Bylokhov]

+1

On 9/21/17 07:54, Semyon Sadetsky wrote:
> Looks good to me.
> 
> --Semyon
> 
> 
> On 09/21/2017 01:44 AM, Pankaj Bansal wrote:
>>
>> Hi Sergey/Seymon,
>>
>> I have incorporated the webrev for review comments.
>>
>> Yes Sergey, the test passes on Ubuntu with GTK L&F.
>>
>> Webrev: 
>> http://cr.openjdk.java.net/~psadhukhan/pankaj/JDK-6857809-webrev.01/ 
>> <http://cr.openjdk.java.net/%7Epsadhukhan/pankaj/JDK-6857809-webrev.01/>
>>
>> Regards,
>>
>> Pankaj Bansal
>>
>> *From:*Semyon Sadetsky
>> *Sent:* Wednesday, September 20, 2017 10:43 PM
>> *To:* Pankaj Bansal; awt-dev at openjdk.java.net
>> *Subject:* Re: <AWT Dev> [10] Review Request: JDK-6857809 : [TEST_BUG] 
>> java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java
>>
>> On 09/20/2017 09:21 AM, Pankaj Bansal wrote:
>>
>>     Hi Seymon,
>>
>>     I think the issue is because no size is set on frame. This is also
>>     the proposed fix in the bug description.
>>
>> This is good, but setting a fixed frame size forces the java Frame 
>> object to return that size only at the very beginning the real and 
>> final frame dimensions will be established  asynchronously by the 
>> native window subsystem.
>>
>>     Regards,
>>
>>     Pankaj
>>
>>     *From:*Semyon Sadetsky
>>     *Sent:* Wednesday, September 20, 2017 9:02 PM
>>     *To:* Pankaj Bansal; awt-dev at openjdk.java.net
>>     <mailto:awt-dev at openjdk.java.net>
>>     *Subject:* Re: <AWT Dev> [10] Review Request: JDK-6857809 :
>>     [TEST_BUG] java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java
>>
>>     Hi Pankaj,
>>
>>     The root cause of the issue is that the underling native window is
>>     not yet created when its with and height are requested. This is
>>     because windows are created asynchronously. The test should be
>>     fixed by adding Robot.waitForIdle() after frame.setVisible(true).
>>
>>     --Semyon
>>
>>     On 09/20/2017 05:49 AM, Pankaj Bansal wrote:
>>
>>         Hi All,
>>
>>         Please review the fix for test program test
>>         java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java
>>         for JDK 10.
>>
>>         Bug:
>>
>>         https://bugs.openjdk.java.net/browse/JDK-6857809
>>
>>         Webrev:
>>
>>         http://cr.openjdk.java.net/~aghaisas/pankaj/6857809/webrev.0/
>>         <http://cr.openjdk.java.net/%7Eaghaisas/pankaj/6857809/webrev.0/>
>>
>>         Issue:
>>
>>         The test
>>          java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java
>>         fails on Linux intermittently due to
>>         “java.lang.IllegalArgumentException: Width (0) and height (0)
>>         cannot be <= 0” exception.
>>
>>         Fix:
>>
>>         Made changes in
>>         java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java to
>>         set the size of frame to make the test more stable.
>>
>>         Regards,
>>
>>         Pankaj Bansal
>>
> 


-- 
Best regards, Sergey.