<AWT Dev> <i18n dev> Fw: [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

Naoto Sato naoto.sato at oracle.com
Tue Dec 11 21:27:46 UTC 2018


Hello,

I would rather not create a new test directory ReconnectTest. Instead, 
moving the test under InputContext would just be fine. Other than that, 
looks good to me.

Naoto

On 12/4/18 6:45 PM, Toshio 5 Nakamura wrote:
> Hello,
> 
> Can anyone support this proposal? I appreciate any suggestion or comment.
> 
> issue:
> https://bugs.openjdk.java.net/browse/JDK-8213183
> webrev:
> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/
> 
> Fix descriptions:
> - XSelectInput() in XMSelection.java may erase existing
>    XRegisterIMInstantiateCallback entry. It should keep the current masks.
> - All input method data in the linked list should be cleared when
>    DestroyXIMCallback() was called.
> 
> Best regards,
> Toshio Nakamura
> 
> "awt-dev" <awt-dev-bounces at openjdk.java.net> wrote on 2018/11/22 15:48:10:
> 
>> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
>> Date: 2018/11/22 15:50
>> Subject: <AWT Dev> Fw: [PATCH] JDK-8213183: InputMethod cannot be
>> used after its restarting
>> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
>>
>> Ping.
>>
>> Thanks,
>> Toshio Nakamura
>>
>> "awt-dev" <awt-dev-bounces at openjdk.java.net> wrote on 2018/11/15
> 17:15:25:
>>
>>> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
>>> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
>>> Date: 2018/11/15 17:16
>>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
>>> used after its restarting
>>> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
>>>
>>> Hello,
>>>
>>> I'd like to re-propose minimized patch in this thread.
>>>
>>> The key fix of this patch is for XMSelection.java. Its initScreen()
> cleared
>>> previous XRegisterIMInstantiateCallback() entry, but it should keep the
>>> current mask. By this change only, we can reuse Input Method after
>>> changing focus.
>>> (Original patch didn't need focus change, but it may be hard to
> bereviewed.)
>>>
>>> Additionally, this change may unveil a potential problem in
>> awt_InputMethod.c.
>>> It needs to clear all pX11IMData, not only the current one. Without
>>> the change,
>>> multi-window application with IM may crash after IM restart.
>>>
>>> So, I'd like to propose only two parts in this thread.
>>> Can I obtain a sponsor for this minimized fix?
>>>
>>> Revised webrev:
>>> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/
>>>
>>> Thanks,
>>> Toshio Nakamura
>>>
>>> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
>>> To: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>>> Cc: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
>>> Date: 2018/11/12 20:22
>>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
>>> used after its restarting
>>> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
>>>
>>>
>>>
>>> Hi Sergey,
>>>
>>> Thank you for your reply. Yes, I've added the steps to the bug.
>>> https://bugs.openjdk.java.net/browse/JDK-8213183
>>>
>>> Please let me know if you have any question or any advice.
>>>
>>> Thanks,
>>> Toshio Nakamura
>>>
>>> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>>> To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, awt-
>>> dev at openjdk.java.net, i18n-dev at openjdk.java.net
>>> Date: 2018/11/10 12:46
>>> Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be
>>> used after its restarting
>>>
>>>
>>>
>>> Hi, Toshio.
>>>
>>> Can you please add the steps to reproduce to the bug description.
>>>
>>> On 06/11/2018 01:19, Toshio 5 Nakamura wrote:
>>>> Hello,
>>>>
>>>> Can I obtain a sponsor of this proposal about InputMethod issue on
> Linux?
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8213183
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.00/
>>>>
>>>> I've got an author role and filled the bug report.
>>>> Please refer the attached mail about the detail of this patch.
>>>>
>>>> Best Regards,
>>>> Toshio Nakamura
>>>
>>> --
>>> Best regards, Sergey.
>>>


More information about the awt-dev mailing list