<AWT Dev> [11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Sat Feb 3 07:56:37 UTC 2018
Hi, Krishna.
The change of local types declarations looks reasonable, but I am not
sure that C99 will be supported by all compilers which will be used to
build jdk where this fix will be used.
I suggest to simplify the fix and add only one null check to it.
On 01/02/2018 04:06, Krishna Addepalli wrote:
> Hi All,
>
> Please review a fix for JDK-8171000:
> https://bugs.openjdk.java.net/browse/JDK-8171000
>
> Webrev: http://cr.openjdk.java.net/~kaddepalli/8171000/webrev00/
>
> The crash happens since XGetImage can return NULL in case of Wayland,
> which doesnot permit reading screen pixels outside the owning window.
> Added a null check to prevent the same, and also refactored and removed
> unnecessary code to make the function simpler.
>
> Thanks,
>
> Krishna
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list