<AWT Dev> Subject: <AWT dev>[11] Review request for JDK-7158623: [macosx] Should an unfocusable maximized Frame be resizable?

[Phil Race]

webrev appears to be against the correct repo :
sh://hg.openjdk.java.net/jdk/client


First can you point to what in the spec. or whatever points to
the correct desired behaviour being what you describe :
 >If the frame is focusable then it is resizable otherwise not.

And regarding the fix, it isn't obvious how adding RESIZABLE changes 
anything here
for the unfocusable case which seems to be the situation that is under 
discussion.

Before: if its unfocusable, then setStyleBits will set the mask to 0 :

     // this is the counter-point to -[CWindow _nativeSetStyleBit:]
     private void setStyleBits(final int mask, final boolean value) {
         execute(ptr -> nativeSetNSWindowStyleBits(ptr, mask, value ? 
mask : 0));
     }

After: .. well exactly the same thing .. you just added a RESIZABLE bit 
that will be ignored.

It may make a difference in the isFocusable case .. but that does not 
match what you
say you are doing.

-phil.

On 02/16/2018 08:17 AM, Kevin Rushforth wrote:
>
> > Kindly review the fix for JDK10.
>
> You mean JDK 11, right?
>
> -- Kevin
>
>
> Manajit Halder wrote:
>> Hi All,
>>
>> Kindly review the fix for JDK10.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-7158623
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mhalder/7158623/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Emhalder/7158623/webrev.00/>
>>
>> Issue:
>> Unfocusable frame was resizable.
>>
>> Fix:
>> After the fix resizability of the frame depends on focusability of 
>> the frame. If the frame is focusable then it is resizable otherwise not.
>> The test code was cleaned to remove old test machinery code.
>>
>> Regards,
>> Manajit
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20180216/052fa408/attachment.html>