<AWT Dev> [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

[Shashidhara Veerabhadraiah]

Hi Krishna, The changes looks fine.

 

Please don't forget to add the bug id to the test before the push. And add this bug JDK-8197810 "as relate to" the current bug(in bug db).

 

Thanks and regards,

Shashi

 

From: Krishna Addepalli 
Sent: Tuesday, July 3, 2018 8:00 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com>; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

 

Hi Shashi,

Thanks for the review. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev01/

 

As for the test, it has already been corrected and pushed in JDK-8197810. 

 

Thanks,

Krishna

 

 

From: Shashidhara Veerabhadraiah 
Sent: Monday, July 2, 2018 11:30 PM
To: Krishna Addepalli <HYPERLINK "mailto:krishna.addepalli at oracle.com"krishna.addepalli at oracle.com>; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

 

Hi Krishna, Below are the comments on the fix that you made.

 

1.      Based on the getSelectedIndex(), I think the selectedIndex should be initialized to -1. 0 seems to be a valid value.

2.      A test may be required to test out the behavior because as per the comment in the bug, the test SelecteCurrentItemTest.html should fail now on all platforms since the passing platforms software was changed.

 

Other than that the changes looks fine.

 

Thanks and regards,
shashi

 

From: Krishna Addepalli 
Sent: Monday, July 2, 2018 3:10 PM
To: HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: <AWT Dev> [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

 

Hi All,

 

Please review a fix for JDK-8014503: https://bugs.openjdk.java.net/browse/JDK-8014503

Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/

 

On Windows, the default behavior has been changed to not send an ItemEvent, if the same item is selected again, whereas this was not changed for Mac and Linux.

This fix changes that behavior, and makes it consistent for all the three platforms.

 

Thanks,

Krishna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20180702/2f609cc2/attachment-0001.html>