<AWT Dev> <AWT dev>[11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

[Sergey Bylokhov]

I still do not understand why the resizable property depends from the 
focusable property? I guess it should depend only on Frame.isResizable().

On 15/06/2018 10:54, Phil Race wrote:
> I would like to refer back to a comment you made in the previous fix
> http://mail.openjdk.java.net/pipermail/awt-dev/2018-February/013626.html
> 
>  > It is not mentioned in the focus spec whether the unfocusable 
> maximized frames should be resizable or not.
> 
> Yet there seems to be a JCK test that says it should not be resizable ?
> 
> Can you review the spec. again ?
> JCK must have based the test on something .. else the test is not valid.
> 
> If we want that behaviour specified .. we should be specifying it ..
> But I am not sure if it is actually enforceable on all window managers / 
> desktops.
> 
> But I have the same issue with this fix as the previous one. Perhaps not 
> the fix,
> but the explanation. The code being changed can't be understood without 
> seeing
> the method it calls, and the native method it in turn calls.
> 
> Can you provide a detailed explanation as to how this change propagates down
> and does the right thing ?
> 
> BTW stylistically - if this is the right fix - you could do :
> 
> setStyleBits(SHOULD_BECOME_KEY | SHOULD_BECOME_MAIN | ((isFocusable) ? 
> RESIZABLE : 0), isFocusable);
> 
> 
> -phil.
> 
> On 06/14/2018 11:37 PM, Manajit Halder wrote:
>> Hi All,
>>
>> Kindly review the fix for JDK11.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8204860
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mhalder/8204860/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Emhalder/8204860/webrev.00/>
>>
>> Fix:
>> Frame is focusable:
>> Retaining the existing frame resizable behaviour (Fixes the current 
>> issue).
>> Frame is non-focusable:
>> Making the Frame non-resizable (Fix for issue 7158623).
>>
>> Regards,
>> Manajit
> 


-- 
Best regards, Sergey.