<AWT Dev> Proposal:X11 default visual support for IM status window on VNC

[Sergey Bylokhov]

Looks fine, if there are no other comments I'll push the fix using the 
new bugid.

On 06/06/2018 17:54, Ichiroh Takiguchi wrote:
> Hello Sergey.
> Thank you for your review.
> 
> Could you review following patch ?
> http://cr.openjdk.java.net/~aleonard/defvis/webrev.01/
> 
> Thanks,
> Ichiroh Takiguchi
> IBM Japan, Ltd.
> 
> On 2018-06-06 07:15, Sergey Bylokhov wrote:
>> Hi, Ichiroh.
>> The approach looks fine, but maybe it is possible to decrees code
>> duplication in findWithTemplate(). After the fix it will have two
>> similar loops.
>>
>> On 24/05/2018 22:24, Ichiroh Takiguchi wrote:
>>> Hello,
>>> IBM would like to contribute X11 default visual support for IM status 
>>> window patch to OpenJDK project.
>>>
>>> Issue:
>>> Java's Native IM status window is not displayed even if it's there.
>>> Because of this issue, user cannot get proper visual feedback during 
>>> key input operation.
>>> We found this issue on Tiger VNC.
>>>
>>> Reason:
>>> Java may pick up unexpected visual for Java's Native IM status window 
>>> when  Xserver supports multiple visual.
>>>
>>> Workaround:
>>> X11 default visual can be changed by FORCEDEFVIS environment 
>>> variable, but it's not easy to find out default visual id.
>>>
>>> I'd like contribute following 2 files:
>>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c
>>> (Change X11 visual setting)
>>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c
>>> (Support 13 point X11 misc fonts (like k14 font for Japanese), since 
>>> the fonts may defined for unscaled fonts.)
>>>
>>> webrev files are in
>>> http://cr.openjdk.java.net/~aleonard/defvis/
>>>
>>> I appreciate any feedback please, and how I would go about obtaining 
>>> a sponsor and contributor?
>>>
>>> Thanks,
>>> Ichiroh Takiguchi
>>> IBM Japan, Ltd.
>>>
> 


-- 
Best regards, Sergey.