<AWT Dev> [11] Review request for 8198605: Touch keyboard is shown for a non-focusable text component

[anton.litvinov at oracle.com]

Hello Sergey,

Thank you for review and approval of this fix.

Do you mean such an RFE may be used for simplification of testing of 
this bug or all possible bugs connected with this new functionality, 
which allows to automatically show and hide the touch keyboard, on a PC 
without a touch screen?

The fix for the bug JDK-8166772 allows to display the touch keyboard on 
clicks from a regular physical mouse, but only for the case, when no 
physical keyboards are attached to the PC and the system setting

"Automatically show the touch keyboard in windowed apps when there's no 
keyboard attached to your device"

is turned on in MS Windows OS. Therefore technically it is possible to 
change the code of "Java_sun_awt_windows_WToolkit_showTouchKeyboard" 
function from the file 
"src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp" to 
check or not to check for presence of any attached keyboards depending 
on some new boolean flag, what will let to test this functionality 
without a touch screen just having a mouse and a physical keyboard. But 
implementation of such a flag, perhaps as a new Java system property, 
will require filing CSR request and describing this flag in the release 
notes. Also testing the functionality related to the touch keyboard 
without a touch screen is testing of not the main use case.

I am ready to create such an RFE and to work on it, if it will be 
beneficial for testing and development purposes, but if a person, who 
tests the functionality and the developer working on the issue has a 
device with a touch screen, then such possible property will simplify 
testing of the functionality only for the narrow case in which a user 
has MS Window 8 OS or later, does not have a touch screen, cannot detach 
the keyboard, since it is part of a laptop, and still wants to use the 
touch keyboard using the regular mouse.

Thank you,
Anton

On 01/03/2018 21:53, Sergey Bylokhov wrote:
> Hi, Anton.
> Looks fine.
>
> ps: maybe we can create some rfe to enable Touch keyboard even if the 
> system has some keyboards for the test purpose?
>
> On 01/03/2018 08:30, anton.litvinov at oracle.com wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198605
>> Webrev: http://cr.openjdk.java.net/~alitvinov/8198605/jdk11/webrev.00
>>
>> The fix extends a number of the required conditions in the method 
>> "sun.awt.windows.WToolkit.showOrHideTouchKeyboard(Component, 
>> AWTEvent)", which should be satisfied for showing of the touch 
>> keyboard, by checking if the component is focusable or not.
>>
>> Thank you,
>> Anton
>
>