<AWT Dev> [11] Review request for 8198606: Touch keyboard does not hide, when a text component looses focus

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Mar 12 14:10:24 UTC 2018


Looks fine.

On 12/03/2018 06:24, Anton Litvinov wrote:
> Hello,
> 
> Could you please review the following fix for the bug.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198606
> Webrev: http://cr.openjdk.java.net/~alitvinov/8198606/jdk11/webrev.00
> 
> The root cause of the bug is the fact that starting from one of the last 
> updates of MS Windows 10 the window of the touch keyboard does not have 
> the style "WS_VISIBLE", even when it is really visible, and the method 
> "AwtToolkit::HideTouchKeyboard()" does not execute the code hiding the 
> touch keyboard, because the method 
> "AwtToolkit::GetTouchKeyboardWindow()" return "NULL", since one of its 
> conditions, particularly "::IsWindowVisible(hwnd)", where "hwnd" is a 
> handle of the touch keyboard window, currently always returns "FALSE".
> 
> The fix for this bug removes this extra "if" condition from the method 
> "AwtToolkit::GetTouchKeyboardWindow()", which in current circumstances 
> is always evaluated as "FALSE".
> 
> Thank you,
> Anton


-- 
Best regards, Sergey.


More information about the awt-dev mailing list