<AWT Dev> [11] Review Request: 8198895 Compilation errors in java.desktop with VS 2017

[Sergey Bylokhov]

On 16/03/2018 10:08, Sergey Bylokhov wrote:
> On 15/03/2018 22:55, Philip Race wrote:
>> Looks OK .. can you confirm this builds without issue with VS2013 as 
>> well, and that some
> 
> I'll recheck that.

I have completed a test run of jtreg+jck on the fix using vs2013, no new 
issues were found.

> 
>> AWT tests that use the components touched are OK ?
> 
> I cannot do that because the build still fails at the end, even for 
> openjdk and if "disable-warnings-as-errors" is passed.
> 
>>
>> -phil
>>
>> On 3/15/18, 10:29 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review fix for jdk11.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8198895
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8198895/webrev.01
>>>
>>> VS2017 produces the warnings when we use casts some integral types to 
>>> pointers or use casts of pointers to types.
>>> The fix simply suppress such warnings using the intermediate casts to 
>>> intptr_t(same approach as in JDK-8196884[1])
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8196884
>>>
> 
> 


-- 
Best regards, Sergey.