<AWT Dev> <AWT dev>[11] Review request for JDK-8202841: [macosx] test java/awt/Graphics/LCDTextAndGraphicsState.java fails

[Phil Race]

Hopefully we can update all 16 tests with the boilerplate developed for 
this test.
One thing that I think needs to change here, is that using interrupt() 
as a way
to signal the main thread doesn't seem ideal.
You can either use a semaphore or it can use a sleep loop waiting for a 
flag to be set.

-phil.



On 05/15/2018 05:19 AM, Manajit Halder wrote:
> Hi Phil,
>
> My observation on test written using manual=yesno:
>
> Found approximately 56 tests containing manual=yesno in awt/ tests. 
> Among these 40 are written using applet and 16 are printing tests 
> (awt/print and awt/PrintJob).
> All the printing test with manual=yesno fails with the same,  whereas 
> applet test were working fine.
>
> Error: "error "test result: Error. Parse Exception: Arguments to 
> `manual' option not supported: yesno”
>
> Jtreg version used: jtreg, version 4.2 dev 380
> JDK version: JDK 11 local build
>
> Regards,
> Manajit
>
>> On 11-May-2018, at 4:51 AM, Philip Race <philip.race at oracle.com 
>> <mailto:philip.race at oracle.com>> wrote:
>>
>> So according to http://openjdk.java.net/jtreg/tag-spec.html this tag 
>> is legal and correct
>>
>> /manual[=(yesno|done)]
>> ...
>> If "yesno" is given, then the harness will ask the user whether the 
>> action is to pass or fail.
>>
>> But it seems this is only implemented for applets.
>>
>> So are those other strings applets or main programs.
>>
>> -phil.
>>
>> On 5/10/18, 1:58 PM, Sergey Bylokhov wrote:
>>> Hi, Manajit.
>>> Did you check other tests with such typos?
>>> I found the same strings in our repo.
>>>
>>> On 10/05/2018 04:59, Manajit Halder wrote:
>>>> Hi Phil,
>>>>
>>>> Please review the test fix for JDK11.
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8202841
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~mhalder/8202841/webrev.00/
>>>>
>>>> Issue:
>>>> Test fails due jtreg tag manual=yesno with error “Parse Exception: 
>>>> Arguments to `manual' option not supported: yesno”
>>>>
>>>> Fix:
>>>> Removed itreg tag manual=yesno and changed the test to a manual 
>>>> test with instructions
>>>>
>>>> Regards,
>>>> Manajit
>>>
>>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20180516/da1eeaf8/attachment.html>