<AWT Dev> OpenJdk11-28-EA JDialog hanging

Martin Balao mbalao at redhat.com
Wed Nov 7 00:45:17 UTC 2018


Hi Sergey,

What the test is doing does not look right to me.

An event whose source app context is associated with "system" thread
group is being posted on the EventQueue of an app context associated
to "TestThreadGroup" thread group. See
"Toolkit.getDefaultToolkit().getSystemEventQueue().postEvent(new
ActionEvent(this, 0, null));" and
"Toolkit.getDefaultToolkit().getSystemEventQueue().postEvent(new
ActionEvent(this, 1, null));" lines. Apparently, if you get the
EventQueue and post directly as the test is doing
("Toolkit.getDefaultToolkit().getSystemEventQueue().postEvent(...)"),
no checks are done in this regard. However, if you use
SunToolkit.postEvent API to post the event, this is checked and an
exception thrown.

The reason why this test is now failing is that the event is re-posted
through SunToolkit.postEvent API in SequencedEvent class. Even though
it would be possible to modify Webrev.03 to use the EventQueue
directly -and bypass the check-, I actually think that this check is
good. So, I suggest to remove this test and keep both Laurent's and
your test.

What do you think?

Thanks,
Martin.-



On Mon, Nov 5, 2018 at 5:01 PM, Sergey Bylokhov
<Sergey.Bylokhov at oracle.com> wrote:
> Hi, Martin.
>
> Can you please recheck the test which was created for JDK-8152974
> http://hg.openjdk.java.net/jdk/jdk/rev/719064f540f3
> It started to fail after this version of the fix.
>
>>   * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.03/
>
>  BTW I have run all our internal tests on this version of the fix, and still
> waiting of the results.
>
>
> --
> Best regards, Sergey.


More information about the awt-dev mailing list