<AWT Dev> Review request for: JDK-8213292 Input freezes after MacOS key-selector (press&hold) usage on macOS Mojave

[Alexey Ushakov]

Hi Sergey,

> - Did you send a bug report to the Apple?

Not yet. Will do so.

> - Is it necessary to have a check for a specific OS or the same approach will work
>   for current and future OS's as well?
I’ll check the fix on macOS 10.13 or lower but I prefer not to touch working code :), so decided to limit the fix impact to only 10.14+
Actually, the OS check  was done using old api for build environment of jdk8u.  It can be rewritten for jdk12 using modern one (https://developer.apple.com/documentation/foundation/nsprocessinfo/1414876-isoperatingsystematleastversion?language=objc)

Best Regards,
Alexey

> On 7 Nov 2018, at 00:13, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Alexey.
> 
> A few questions:
> - Did you send a bug report to the Apple?
> - Is it necessary to have a check for a specific OS or the same approach will work
>   for current and future OS's as well?
> 
> On 02/11/2018 07:15, Alexey Ushakov wrote:
>> Hello,
>> Here is the fix of input accented symbols on macOS 10.14 for openjdk12, please have a look. The problem is also reproducible in JDK8-JDK11
>> Bug :https://bugs.openjdk.java.net/browse/JDK-8213292
>> Webrev :http://cr.openjdk.java.net/~avu/JDK-8213292/webrev.00/
>>  Issue : The recent version of macOS (10.14) breaks the input of accented symbols using key-select input method. This is a major problem for all IntelliJ IDEA Platform based products (https://youtrack.jetbrains.com/issue/JRE-998). After entering accented symbol a user is unable to enter any ordinary symbol.
>> Root cause : For some reason jdk after entering accented symbol started to receive NSEvent objects having willBeHandledByComplexInputMethod property set to 1 even for ordinary symbols
>> Solution : Calling abandonInput method of AWTView object restores the correct behavior of input methods
>> Best Regards,
>> Alexey
> 
> 
> -- 
> Best regards, Sergey.