<AWT Dev> <AWT dev>[12] Review request for JDK-8213522: [TEST_BUG] 16 java/awt/Focus test cases fails on Mac OS when run in group but passes individually
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Thu Nov 8 18:40:20 UTC 2018
Hi, Manajit.
> The 2 event test cases passes but looks like robot key operations doesn’t wait until all the events currently on the event queue are processed. Added autoWaitForIdle to fix the issue.
It is unclear what is wrong in these tests, for example:
http://cr.openjdk.java.net/~mhalder/8213522/webrev.00/test/jdk/java/awt/event/KeyEvent/KeyChar/KeyCharTest.java.sdiff.html
You dropped the two calls to waitForIdle() and call setAutoWaitForIdle() which actually will produce the similar calls to waitForIdle() after keyPress() and keyRelease(). So the only visible change is delay(500), but can you please clarify why it depends on the order of tests?
Same for this test:
http://cr.openjdk.java.net/~mhalder/8213522/webrev.00/test/jdk/java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java.sdiff.html
The only visible change is robot.delay(500), in others places the test has delay(100) which should be enough for clicks, how it might affect other tests?
BTW the line below should be after the "test()"
80 System.out.println("key_pressed count: " + keyPressedCount);
--
Best regards, Sergey.
More information about the awt-dev
mailing list