<AWT Dev> [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

[Ambarish Rapte]

Thanks for the review Sergey & Krishna,
I shall remove the wild card imports and check in the change.

Regards,
Ambarish

-----Original Message-----
From: Krishna Addepalli 
Sent: Friday, November 09, 2018 5:08 PM
To: Sergey Bylokhov <sergey.bylokhov at oracle.com>; Ambarish Rapte <ambarish.rapte at oracle.com>; awt-dev at openjdk.java.net
Subject: RE: <AWT Dev> [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Hi Ambarish,

Looks fine to me as well.
Could you also remove the wildcard imports in the test? I don't need to see a new webrev - just do the changes and push it.

Thanks,
Krishna

-----Original Message-----
From: Sergey Bylokhov 
Sent: Thursday, November 8, 2018 10:41 PM
To: Ambarish Rapte <ambarish.rapte at oracle.com>; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Hi, Ambarish.

Thank you for clarification, looks fine.

On 08/11/2018 02:52, Ambarish Rapte wrote:
> Hi Sergey,
>> But after the window will become visible, what state it will have? It will be "maximized" or "normal" window?
> 
> This issue occurs when extended state is set to MAXIMIZED_BOTH i.e. setExtendedState(Frame.MAXIMIZED_BOTH)
> Immediately after this call, getExtendedState() correctly returns MAXIMIZED_BOTH (6) state and,
> getState() returns the default state i.e. NORMAL(0).
> 
> Both before and after the window becomes visible, state and extended state values remain same.
> 
> Regards,
> Ambarish
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Thursday, November 08, 2018 12:27 AM
> To: Ambarish Rapte <ambarish.rapte at oracle.com>; awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev> [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows
> 
> On 07/11/2018 02:47, Ambarish Rapte wrote:
>> 4.  When the Frame.MAXIMIZED_BOTH extended state is set while the window is not visible, the state is saved,
>> ---  on java side in Frame.java::state variable and
>> ---  on native side in awtFrame::m_zoomed variable.
>> ---  But it is not actually applied to the window, i.e. WS_MAXIMIZE bit would be 0 and we do not access the style.
> 
> But after the window will become visible, what state it will have? It will be "maximized" or "normal" window?
> 
> 


-- 
Best regards, Sergey.