<AWT Dev> RFR 8213532: add missing LocalFree calls after using FormatMessage(A) [windows]
Dmitry Markov
dmitry.markov at oracle.com
Wed Nov 14 12:06:01 UTC 2018
Hi Matthias,
The fix looks good.
Thanks,
Dmitry
> On 14 Nov 2018, at 07:48, Baesken, Matthias <matthias.baesken at sap.com> wrote:
>
> Hi Sergey, thanks for the review !
>
> Could I have a second review please, before I push the change ?
>
> Best regards, Matthias
>
>
>> -----Original Message-----
>> From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>> Sent: Freitag, 9. November 2018 21:50
>> To: Baesken, Matthias <matthias.baesken at sap.com>; awt-
>> dev at openjdk.java.net
>> Subject: Re: RFR 8213532: add missing LocalFree calls after using
>> FormatMessage(A) [windows] - was RE: <AWT Dev> FW: RFR [XS] : 8213366:
>> (fs) avoid handle leak in
>> Java_sun_nio_fs_WindowsNativeDispatcher_FindFirstFile0
>>
>> Looks fine.
>>
>> On 08/11/2018 08:20, Baesken, Matthias wrote:
>>> Hello, looks like I used the wrong DTRACE_PRINTLN* call at one place in
>> src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp .
>>> New webrev :
>>>
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8213532.1/
>>>
>>> Regards, Matthias
>>>
>>>
>
More information about the awt-dev
mailing list