<AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be used after its restarting

[Toshio 5 Nakamura]

Hello,

I'd like to re-propose minimized patch in this thread.

The key fix of this patch is for XMSelection.java. Its initScreen() cleared
previous XRegisterIMInstantiateCallback() entry, but it should keep the
current mask. By this change only, we can reuse Input Method after
changing focus.
(Original patch didn't need focus change, but it may be hard to be
reviewed.)

Additionally, this change may unveil a potential problem in
awt_InputMethod.c.
It needs to clear all pX11IMData, not only the current one. Without the
change,
multi-window application with IM may crash after IM restart.

So, I'd like to propose only two parts in this thread.
Can I obtain a sponsor for this minimized fix?

Revised webrev:
http://cr.openjdk.java.net/~tnakamura/8213183/webrev.01/

Thanks,
Toshio Nakamura

From:	"Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
To:	Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
Cc:	awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
Date:	2018/11/12 20:22
Subject:	Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be used
            after its restarting
Sent by:	"awt-dev" <awt-dev-bounces at openjdk.java.net>



Hi Sergey,

Thank you for your reply. Yes, I've added the steps to the bug.
https://bugs.openjdk.java.net/browse/JDK-8213183

Please let me know if you have any question or any advice.

Thanks,
Toshio Nakamura

Inactive hide details for Sergey Bylokhov ---2018/11/10 12:46:19---Hi,
Toshio. Can you please add the steps to reproduce to theSergey Bylokhov
---2018/11/10 12:46:19---Hi, Toshio. Can you please add the steps to
reproduce to the bug description.

From: Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
To: Toshio 5 Nakamura <TOSHIONA at jp.ibm.com>, awt-dev at openjdk.java.net,
i18n-dev at openjdk.java.net
Date: 2018/11/10 12:46
Subject: Re: <AWT Dev> [PATCH] JDK-8213183: InputMethod cannot be used
after its restarting



Hi, Toshio.

Can you please add the steps to reproduce to the bug description.

On 06/11/2018 01:19, Toshio 5 Nakamura wrote:
> Hello,
>
> Can I obtain a sponsor of this proposal about InputMethod issue on Linux?
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8213183
> Webrev:
> http://cr.openjdk.java.net/~tnakamura/8213183/webrev.00/
>
> I've got an author role and filled the bug report.
> Please refer the attached mail about the detail of this patch.
>
> Best Regards,
> Toshio Nakamura
>
> ----- Forwarded by Toshio 5 Nakamura/Japan/IBMon 2018/11/06 18:08-----
>
> From: "Toshio 5 Nakamura" <TOSHIONA at jp.ibm.com>
> To: awt-dev at openjdk.java.net, i18n-dev at openjdk.java.net
> Date: 2018/06/26 17:46
> Subject: <AWT Dev> Proposal: Input Method re-connection
> Sent by: "awt-dev" <awt-dev-bounces at openjdk.java.net>
>
>
> Hello,
>
> I'd like to contribute a proposal about Input Method (IM) re-connection
> on Linux. This is a part of contribution of IBM enhancements.
>
> Issue:
> After IM process (fcitx, kinput2, etc.) was down, Java GUI application
> cannot use it even if IM process is restarted. This change try to
> re-connect IM when its process was restarted on Linux.
>
> Description of changes:
> - XRegisterIMInstantiateCallback is set in DestroyXIMCallback.
> - Saved the latest activated X11InputMethod instance and use it to
> call its activate method in the instantiate callback.
> - XSelectInput in XMSelection.java may reset the
> XRegisterIMInstantiateCallback entry, so it's changed to keep the
> current registers.
>
> Patch:_
>
__http://cr.openjdk.java.net/~aleonard/im_resume/webrev.00/_

> (I asked my colleague to store my patch for easy reference.
> I'm a contributor and need a sponsor of the proposal.)
>
> Could I ask someone to kindly become a sponsor of this proposal?
>
> Thanks,
> Toshio Nakamura, IBM Japan
>


--
Best regards, Sergey.




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20181115/532ab449/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1A896936.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20181115/532ab449/1A896936.gif>