<AWT Dev> [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

[Dmitry Markov]

Hi Krishna,

You are right. I have updated the fix: now we skip ordering if one of the child windows is popup. Please find new version here: http://cr.openjdk.java.net/~dmarkov/8213983/webrev.01/ <http://cr.openjdk.java.net/~dmarkov/8213983/webrev.01/>

Thanks,
Dmitry

> On 21 Nov 2018, at 17:43, Krishna Addepalli <krishna.addepalli at oracle.com> wrote:
> 
> Hi Dmitry,
> 
> While I understand that you donot want to order the windows when the popup window is present as a child of the root window, I did not understand, why you need to check if the total number of windows should be only one.
> If I understand correctly, if a modal dialog/any other child window has a ComboBox component in it, then PopupMenu will be an additional window, and the length may not necessarily be equal to one.
> 
> Thanks,
> Krishna
> 
>> On 21-Nov-2018, at 10:10 PM, Dmitry Markov <dmitry.markov at oracle.com <mailto:dmitry.markov at oracle.com>> wrote:
>> 
>> Hello,
>> 
>> Could you review a fix for jdk12, please?
>> 
>>  	bug: https://bugs.openjdk.java.net/browse/JDK-8213983 <https://bugs.openjdk.java.net/browse/JDK-8213983>
>>  	webrev: http://cr.openjdk.java.net/~dmarkov/8213983/webrev.00/ <http://cr.openjdk.java.net/~dmarkov/8213983/webrev.00/>
>> 
>> On OS X the keyboard shortcut “cmd +`” stops working properly if a popup window is displayed. That behaviour is caused by window ordering operation. However it is really unnecessary to perform ordering for popup windows because they are located at another window level, (i.e. NSPopUpMenuWindowLevel) and always placed above their parents.
>>  
>> Thanks,
>> Dmitry 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20181121/51cd877a/attachment-0001.html>