<AWT Dev> RFR: [XS] 8214380: AwtDragSource function LoadCache misses a ReleaseLongArrayElements in special case

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Nov 28 23:21:35 UTC 2018


Hi, Matthias.

Do we need the null check in the fix, if "yes" then probably
the same check should be added before this line as well?
   465     env->ReleaseLongArrayElements(formats, saveFormats, 0);

On 28/11/2018 00:33, Baesken, Matthias wrote:
> Hello, please review  this small fix.
> 
> It adds a missing ReleaseLongArrayElements  to
> 
> void AwtDragSource::LoadCache(jlongArray formats)
> 
> in an early special   “pseudo return”  (leave function via throw)  case.
> 
> Webrev/bug :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8214380.0/
> 
> https://bugs.openjdk.java.net/browse/JDK-8214380
> 
> Thanks, Matthias
> 


-- 
Best regards, Sergey.


More information about the awt-dev mailing list