<AWT Dev> [12] Review Request: 8211822 and 8202886

Igor Ignatyev igor.ignatyev at oracle.com
Thu Oct 11 03:04:50 UTC 2018


Hi Sergey,

the changes in NSTexturedJFrame and 7154841 tests look good to me.

-- Igor

> On Oct 7, 2018, at 4:41 PM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hello.
> Please review the fix for jdk12.
> 
> Bug: Some tests fail after JDK-8210039
>     https://bugs.openjdk.java.net/browse/JDK-8211822
> Bug: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS
>     https://bugs.openjdk.java.net/browse/JDK-8202886
> Webrev: http://cr.openjdk.java.net/~serb/8211822/webrev.00
> 
> These tests use the ExtendedRobot which is located in the library, but the fix for JDK-8210039 changed the path to the library, since it assumed only OSInfo was used there, and it missed ExtendedRobot. As a fix the "/test/jdk/lib/testlibrary/" library was added back.
> 
> One of the test above fails, because of JDK-8202886, the root cause is the using of the shortcuts to iterate the global menu, which are not necessary configured or might be changed. As a fix the test will use mouse clicks.
> 
> -- 
> Best regards, Sergey.



More information about the awt-dev mailing list