<AWT Dev> [12] RFR : JDK-8198000 : java/awt/List/EmptyListEventTest/EmptyListEventTest.java debug assert on Windows

[Ambarish Rapte]

Hi,

                Please review this Windows only fix,

                JBS: https://bugs.openjdk.java.net/browse/JDK-8198000

                Webrev: http://cr.openjdk.java.net/~arapte/8198000/webrev.00/

 

Issue:

Test asserts with debug build jdk, only on windows.
Assert at Line no 77, awt_List.h :: IsItemSelected()
awt_List.cpp  ::  AwtList::HandleEvent() calls IsItemSelected() with an incorrect index value. 
In AwtList::HandleEvent() , the call SendListMessage(LB_ITEMFROMPOINT, 0, msg->lParam)  returns an arbitrary value 131071, which gets passed to IsItemSelected().
Could not find any relevance to the value 131071, from LB_ITEMFROMPOINT doc.

 

Fix:  Index should be verified before making call to IsItemSelected() : http://cr.openjdk.java.net/~arapte/8198000/webrev.00/

 

Verification:  All list tests pass.

 

Regards,

Ambarish
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20181029/b963e2da/attachment.html>