<AWT Dev> [12] RFR : JDK-8198001 : java/awt/Menu/WrongParentAfterRemoveMenu/WrongParentAfterRemoveMenu.java debug assert on Windows

[Phil Race]

+ * @bug 8165769, 8198001 Are commas allowed ? 
http://openjdk.java.net/jtreg/tag-spec.html
>Argument tokens are separated by whitespace; if commas are used,  >they will be considered to be part of the tokens to which they are 
adjacent. So you now have a bug id of "8165769," acc. to these parsing 
rules. So I think you should use just spaces -phil.

On 10/30/18 9:45 AM, Ambarish Rapte wrote:
>
> Hi Phil,
>
> Thanks for the review comments.
>
> Please take a look at updated webrev: 
> http://cr.openjdk.java.net/~arapte/8198001/webrev.01/
>
> Updated the test with bud ID.
>
> The test is not included in problem list.
>
> Regards,
>
> Ambarish
>
> *From:*Phil Race
> *Sent:* Tuesday, October 30, 2018 12:46 AM
> *To:* Ambarish Rapte <ambarish.rapte at oracle.com>; awt-dev at openjdk.java.net
> *Subject:* Re: <AWT Dev> [12] RFR : JDK-8198001 : 
> java/awt/Menu/WrongParentAfterRemoveMenu/WrongParentAfterRemoveMenu.java 
> debug assert on Windows
>
> The failing test should be updated with this bug id. Else it looks 
> like a fix with no regression test.
> Also if this was on the problem list (probably not if it only failed 
> in debug builds) it
> should be removed.
>
> -phil.
>
> On 10/29/18 9:29 AM, Ambarish Rapte wrote:
>
>     Hi,
>
>     Please review this windows only fix:
>
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8198001
>
>     Webrev: http://cr.openjdk.java.net/~arapte/8198001/webrev.00/
>
>     Issue:
>
>      1. Test asserts with debug build jdk, only on windows.
>      2. This test fails when Menu is removed from MenuBar
>         (WrongParentAfterRemoveMenu.java  :: Line no 100)
>      3. Assert at Line no. 209, awt_MenuBar.cpp :: RedrawMenuBar()
>      4. AwtMenuBar::DeleteItem() ->  AwtMenuBar::RedrawMenuBar()  =>
>         calls GetOwnerHWnd() which returns NULL.
>
>     Fix:  Value returned by GetOwnerHWnd() should be checked for NULL
>     value.
>
>     Verification: All MenuBar tests pass.
>
>     Regards,
>
>     Ambarish
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20181030/e0a14275/attachment-0001.html>