<AWT Dev> [12] Review Request: 8170937 Swing apps are slow if displaying from a remote source to many local displays

Alexey Ivanov alexey.ivanov at oracle.com
Tue Sep 11 19:16:45 UTC 2018


Hi Sergey,

Looks good.

However, some comments need to be corrected:

844      * produce wrong result.
produces…

  853      *  When two screens are overlap and the first contain a 
dock(*****), then
  854      *  _NET_WORKAREA may start at point x1,y1 and ends at point 
x2,y2.
When two screens overlap and the first contains a dock(*****), then
_NET_WORKAREA may start at point x1,y1 and end at point x2,y2.

  926      *    calculated, but the system panels are not necessary 
contain these
  927      *    hints(Gnome 3 for example).
…the system panels do not necessarily contain…


Regards,
Alexey

On 10/09/2018 23:32, Phil Race wrote:
> Looks good. Maybe update this comment before you push ?
>
>  921      * This method is unused because of two reasons:
>
> ".. unused by default ..." ?
>
> -phil.
>
> On 9/10/2018 3:13 PM, Sergey Bylokhov wrote:
>> Hi, Phil.
>> On 10/09/2018 13:20, Phil Race wrote:
>>> But should we consider a switch that allows people to still get the 
>>> long, slow, ideal answer ?
>>
>> Yes it is possible to add a non-public/unsupported property(only as a 
>> workaround for possible bugs):
>> http://cr.openjdk.java.net/~serb/8170937/webrev.02
>> But at some point(jdk12/13?) we can drop it.
>>
>>
>



More information about the awt-dev mailing list