<AWT Dev> RFR [XS] 8229023: make java/awt/print/PrinterJob/SameService.java Windows-only , was : question regarding test java/awt/PrinterJob/SameService.java (tests that print services are not re-created)

[Baesken, Matthias]

Hello,  please review the following small  test adjustment .

It makes the   test   java/awt/print/PrinterJob/SameService.java   Windows-only.

Reason is that in some cases the print service  is recreated on Linux .
( we observed this in ~ 30 % of test runs on one of our test machines )

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8229023

http://cr.openjdk.java.net/~mbaesken/webrevs/8229023.0/


Thanks, Matthias



Hello, I have a question regarding   the test  java/awt/PrinterJob/SameService.java  ;  the test deals with    @bug 6446094   .

It checks that  print services   are not re-created  ,   which was  addressed  (or at least discussed )  in   6446094 ,
See
https://bugs.openjdk.java.net/browse/JDK-6446094

Win32PrintServiceLookup.getPrintServiceByName() should not recreate duplicate instances.


However  6446094  just  talks about Windows ,  and I see  sporadic   failures on some Linux   test machine  in  java/awt/PrinterJob/SameService.java
  because  the print service is   (seldom)   recreated  on Linux   ( it is even non-deterministic, on the same machine the test  fails in ~ 30 % of runs and succeeds  in the other cases ) .

Can we make the test  Windows-only     ( I think the API does not  guarantee   that  print services   are not re-created   , although it is  desired )   ?

Best regards, Matthias


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190802/3c8a664c/attachment-0001.html>