<AWT Dev> [14] Review Request: 8232226 [macos 10.15] test/jdk/java/awt/color/EqualityTest/EqualityTest.java may fail

[Pankaj Bansal]

+1

Pankaj

-----Original Message-----
From: Philip Race 
Sent: Thursday, December 5, 2019 9:26 AM
To: Sergey Bylokhov
Cc: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> [14] Review Request: 8232226 [macos 10.15] test/jdk/java/awt/color/EqualityTest/EqualityTest.java may fail

+1

-phil

On 12/4/19, 7:34 PM, Sergey Bylokhov wrote:
> Any volunteers to review? =)
>
> On 10/17/19 11:23 pm, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for JDK 14.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232226
>> Fix: http://cr.openjdk.java.net/~serb/8232226/webrev.00
>>
>> This test creates a Color object on top of the SystemColor and checks 
>> that the "equals()" will work properly for these two objects. But the 
>> test uses Color(int RGB) constructor which skips the alpha channel of 
>> the color. So the test fails if the SystemColor is transparent.
>>
>> Actual change in the test is:
>>   - Color color = new Color(system.getRGB());
>>   + Color color = new Color(system.getRGB(), system.getAlpha() < 
>> 255);
>>
>> But in the webrev it appears as a new test because it is moved from 
>> the closed repo.
>>
>
>