<AWT Dev> [14] Review Request: 8235739 Rare NPE at WComponentPeer.getGraphics()

[Dmitry Markov]

+1

Thanks,
Dmitry

> On 13 Dec 2019, at 19:12, Alexey Ivanov <alexey.ivanov at oracle.com> wrote:
> 
> On 12/12/2019 23:14, Sergey Bylokhov wrote:
>> On 12/12/19 7:58 am, Alexey Ivanov wrote:
>>> Shall we return null if wpeer is already null?
>>> Rather than falling back to this.surfaceData.
>> 
>> wpeer is a peer of the window which contains the current component,
>> probably if it is null then the window was disposed of already, but
>> since the current method is in the peer as well(the peer of the
>> component) then we will try to use its surface if it was not
>> disposed of yet.
> 
> Makes sense.
> Looks good to me.
> 
> Regards,
> Alexey
> 
>> 
>>> 
>>> On 11/12/2019 22:31, Sergey Bylokhov wrote:
>>>> webrev is re-uploaded.
>>>> 
>>>> On 12/10/19 9:23 pm, Sergey Bylokhov wrote:
>>>>> Hello.
>>>>> Please review the fix for JDK 14.
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8235739
>>>>> Fix: http://cr.openjdk.java.net/~serb/8235739/webrev.00
>>>>> 
>>>>> In the WComponentPeer.getGraphics() we may get NPE because
>>>>> AWTAccessor....getPeer("window") can return null if the "window"
>>>>> was disposed already and its peer was set to null.