<AWT Dev> [14] Review Request: 8234706 MenuPeer cleanup

[Phil Race]

On 12/1/19 8:29 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 14.

for 15 now.

>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234706
> Fix: http://cr.openjdk.java.net/~serb/8234706/webrev.00

>
> The "java.awt.peer.MenuPeer" interface has the "addSeparator" method
> which is unused by the java.awt.Menu since 1995. But we still
> implement this method in all toolkits.
>
> Also the "WMenuPeer.addItem()" method uses "itemPeer" variable
> which is unused since 1996...

meaning this :
http://cr.openjdk.java.net/~serb/8234706/webrev.00/src/java.desktop/windows/classes/sun/awt/windows/WMenuPeer.java.udiff.html

      public void addItem(MenuItem item) {
- WMenuItemPeer itemPeer = (WMenuItemPeer) WToolkit.targetToPeer(item);


>
> Both cases are cleaned. Mach5 is green.
>

Ok. Approved.

-phil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20191217/a37b08ff/attachment.htm>