<AWT Dev> <AWT dev>[13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically.

[Prasanta Sadhukhan]

Hi Manajit,

I see that IconObserver object is used in updateNativeImage()
209 CImage cimage = CImage.getCreator().createFromImage(image, 
observer); 210 boolean imageAutoSize = target.isImageAutoSize(); If 
there is an invalid tray icon target, then wouldn't it cause NPE @210 also?
211 cimage.execute(imagePtr -> { can cimage be null? in that case 211 
can cause NPE too? Also, I see that target is made null during 
dispose(), can you check is it null because TrayIcon is disposed? 
Regards Prasanta
On 05-Feb-19 3:21 PM, Manajit Halder wrote:
> Hi All,
>
> Please review the fix for JDK13.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8207938
>
> Webrev:
> http://cr.openjdk.java.net/~mhalder/8207938/webrev.00/ 
> <http://cr.openjdk.java.net/%7Emhalder/8207938/webrev.00/>
>
> Fix:
> Problem occur while trying to update native image with invalid tray 
> icon target in the imageUpdate callback.
>
> Regards,
> Manajit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190205/db45198a/attachment-0001.html>