<AWT Dev> [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

Krishna Addepalli krishna.addepalli at oracle.com
Wed Jan 16 17:59:37 UTC 2019


Hi Sergey,
I checked the code, by putting logs and can confirm that an event is not generated even if the same is reselected. 
I have updated the test case to reflect this fact, so here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev01/ <http://cr.openjdk.java.net/~kaddepalli/8215921/webrev01/>

Thanks,
Krishna

> On 16-Jan-2019, at 12:50 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Krishna.
> 
> On 15/01/2019 08:52, Krishna Addepalli wrote:
>> While fixing JDK-8014503 <https://bugs.openjdk.java.net/browse/JDK-8014503>, the check for newly selected index and the currently selected index was applied wherever there was a postEvent for the same. However, for the case of mouseRelease, the check is already performed since it tracks two things already - dragStartId and newIdx, and posts an event only if both are not same.
> 
> Can you please clarify the description above, how the usage of "dragStartId" and "newIdx" at line 472 are related to the check which you drop?
> After the current version you will post an event if the same element is reelected.
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190116/e68b687a/attachment.html>


More information about the awt-dev mailing list