<AWT Dev> [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Tue Jan 29 09:57:00 UTC 2019 


On 29-Jan-19 3:21 PM, Krishna Addepalli wrote:
> Hi Prasanta,
> Thanks for the review. I modified the test case as per the 
> suggestions, and also removed the suggested line from the ProblemList.txt.
> I’m using delay explicitly in some places, so that anybody running 
> this test alone, can get a visual cue as to what is happening. Removed 
> the other setAutoDelay call.
OK. looks good.
There is 2 setAutoDelay() call one for 500 and one for 250. You can 
remove one while you push...no need for new webrev

Regards
Prasanta
> Here is the updated webrev: 
> http://cr.openjdk.java.net/~kaddepalli/8215921/webrev05 
> <http://cr.openjdk.java.net/%7Ekaddepalli/8215921/webrev05>
>
> Thanks,
> Krishna
>
>> On 29-Jan-2019, at 2:05 PM, Prasanta Sadhukhan 
>> <prasanta.sadhukhan at oracle.com 
>> <mailto:prasanta.sadhukhan at oracle.com>> wrote:
>>
>> Hi Krishna,
>>
>> Fix looks ok..In testcase, I guess you do not need
>> import javax.management.RuntimeErrorException; and also the 
>> formatting of try-catch block of run() method needs to be corrected. 
>> Also, I do not think you need to call Robot.setAutoDelay() multiple 
>> times, it's one-time setting and if you call that, you do not need 
>> Robot.delay() to be called as whatever time you set in autoDelay will 
>> be used to delay after generating events. And while you are at it, I 
>> guess you should also delete the 
>> java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html 
>> 8192929 windows-all,linux-all from ProblemList Regards Prasanta
>> On 29-Jan-19 1:37 AM, Sergey Bylokhov wrote:
>>> Looks fine.
>>>
>>> On 28/01/2019 09:03, Krishna Addepalli wrote:
>>>> Hi Sergey,
>>>>
>>>> I corrected the test case to work on Mac, and here is the updated 
>>>> webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev04
>>>>
>>>> Thanks
>>>> Krishna
>>>>
>>>>
>>>>> On 24-Jan-2019, at 3:39 AM, Sergey Bylokhov 
>>>>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> 
>>>>> wrote:
>>>>>
>>>>> On 23/01/2019 14:00, Philip Race wrote:
>>>>>> Do you mean that the test may be showing up a problem on macos ?
>>>>>
>>>>> The fix does not affect the macOS, but the test does not
>>>>> check the usecase which it is supposed to verify.
>>>>>
>>>>>> -phil.
>>>>>> On 1/23/19, 1:43 PM, Sergey Bylokhov wrote:
>>>>>>> Hi, Krishna.
>>>>>>>
>>>>>>> I tried a new version of the fix on macOS, and looks
>>>>>>> like the second click is never success, the test always
>>>>>>> fails to open the list of items and as a result clicked
>>>>>>> on the desktop instead of the same element in the list.
>>>>>>>
>>>>>>> On 23/01/2019 09:33, Phil Race wrote:
>>>>>>>> This looks OK so long as you can confirm that you re-tested all 
>>>>>>>> related tests, not
>>>>>>>> just your regression test after making the source code update ...
>>>>>>>>
>>>>>>>> -phil.
>>>>>>>>
>>>>>>>> On 1/21/19 5:00 AM, Krishna Addepalli wrote:
>>>>>>>>> Hi Sergey,
>>>>>>>>>
>>>>>>>>> I have modified the test as you suggested. Here is the new 
>>>>>>>>> webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev03/
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Krishna
>>>>>>>>>
>>>>>>>>>> On 19-Jan-2019, at 3:39 AM, Sergey Bylokhov 
>>>>>>>>>> <Sergey.Bylokhov at oracle.com 
>>>>>>>>>> <mailto:Sergey.Bylokhov at oracle.com> 
>>>>>>>>>> <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi, Krishna.
>>>>>>>>>>
>>>>>>>>>> Can you, please, in the test add a check after each mouse 
>>>>>>>>>> click, that
>>>>>>>>>> the new/same value is selected. This will doublecheck this 
>>>>>>>>>> comments:
>>>>>>>>>> =====
>>>>>>>>>> 112         //make sure that the mouse moves to a different 
>>>>>>>>>> item, so that
>>>>>>>>>> 113         //itemStateChanged is called.
>>>>>>>>>> =====
>>>>>>>>>> 119         //now click on the same item and make sure that 
>>>>>>>>>> item event is
>>>>>>>>>> 120         //not generated.
>>>>>>>>>> =====
>>>>>>>>>>
>>>>>>>>>> On 18/01/2019 04:08, krishna.addepalli at oracle.com 
>>>>>>>>>> <mailto:krishna.addepalli at oracle.com> 
>>>>>>>>>> <mailto:krishna.addepalli at oracle.com> wrote:
>>>>>>>>>>> Hi Sergey, Phil,
>>>>>>>>>>> I have tested the new test case in Windows, Mac, Linux, and 
>>>>>>>>>>> found that it runs on all 3 platforms without any problems.
>>>>>>>>>>> I have also tested all the regressions that were raised, and 
>>>>>>>>>>> all of them passed. In addition, I ran all the awt/Choice 
>>>>>>>>>>> jtreg tests, and found no new failures.
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Krishna
>>>>>>>>>>> *From:*Krishna Addepalli
>>>>>>>>>>> *Sent:* Thursday, January 17, 2019 8:34 PM
>>>>>>>>>>> *To:* Sergey Bylokhov <sergey.bylokhov at oracle.com 
>>>>>>>>>>> <mailto:sergey.bylokhov at oracle.com> 
>>>>>>>>>>> <mailto:sergey.bylokhov at oracle.com> 
>>>>>>>>>>> <mailto:sergey.bylokhov at oracle.com>>
>>>>>>>>>>> *Cc:* awt-dev at openjdk.java.net 
>>>>>>>>>>> <mailto:awt-dev at openjdk.java.net> 
>>>>>>>>>>> <mailto:awt-dev at openjdk.java.net> 
>>>>>>>>>>> <mailto:awt-dev at openjdk.java.net>
>>>>>>>>>>> *Subject:* Re: <AWT Dev> [12]RFR: JDK-8215921: There is no 
>>>>>>>>>>> change when select different Foreground and Background by 
>>>>>>>>>>> mouse.
>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>> The test case was leading my reasoning astray! Yes you are 
>>>>>>>>>>> right that we post event even for the same item selected again.
>>>>>>>>>>> I have updated the fix and the test case well, which checks 
>>>>>>>>>>> if an ItemEvent is generated when a new item is selected and 
>>>>>>>>>>> then it is not generated when the same item is selected again.
>>>>>>>>>>> Here is the updated webrev: 
>>>>>>>>>>> http://cr.openjdk.java.net/~kaddepalli/8215921/webrev02
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Krishna
>>>>>>>>>>> On 17-Jan-2019, at 1:30 AM, Sergey Bylokhov 
>>>>>>>>>>> <Sergey.Bylokhov at oracle.com 
>>>>>>>>>>> <mailto:Sergey.Bylokhov at oracle.com> 
>>>>>>>>>>> <mailto:Sergey.Bylokhov at oracle.com><mailto:Sergey.Bylokhov at oracle.com>> 
>>>>>>>>>>> wrote:
>>>>>>>>>>> On 16/01/2019 09:59, Krishna Addepalli wrote:
>>>>>>>>>>> Hi Sergey,
>>>>>>>>>>> I checked the code, by putting logs and can confirm that an 
>>>>>>>>>>> event is not generated even if the same is reselected.
>>>>>>>>>>> I have updated the test case to reflect this fact, so here 
>>>>>>>>>>> is the new webrev: 
>>>>>>>>>>> http://cr.openjdk.java.net/~kaddepalli/8215921/webrev01/
>>>>>>>>>>> But why it is not generated? How (!firstPress || wasDragged 
>>>>>>>>>>> ) prevents it to be posted?
>>>>>>>>>>> From the code it looks like when "wasDragged==true" or 
>>>>>>>>>>> "firstPress==false" we will post an event.
>>>>>>>>>>> --     Best regards, Sergey.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> -- 
>>>>>>>>>> Best regards, Sergey.
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>>> -- 
>>>>> Best regards, Sergey.
>>>>
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190129/bcb0ef5a/attachment-0001.html>

More information about the awt-dev mailing list