<AWT Dev> [13] Review Request: 8216318 The usage of Disposer in the java.awt.Robot can be deleted

Phil Race philip.race at oracle.com
Wed Jan 30 21:53:27 UTC 2019


Looks fine. I can only suppose the C++ AwtRobot class existed only
because other peer classes need a C++ native object ?
But I can't think what would break if there's none here ...

-phil.

On 1/11/19 6:45 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216318
> Webrev: http://cr.openjdk.java.net/~serb/8216318/webrev.01
>
> Every java.awt.Robot object register a RobotDisposer which
> are responsible to delete the native data of the robot. But
> there is no native data on linux/mac, so RobotDisposer is
> a noop on these platforms. On windows the native c++ class
> "AwtRobot" and the code responsible for allocation/deallocation
> its objects can be removed.
>



More information about the awt-dev mailing list