<AWT Dev> 8221405: Fix Windows 32bit awt build

Alexey Ivanov alexey.ivanov at oracle.com
Tue Mar 26 13:36:36 UTC 2019


Hi Thomas,

Looks good, I'm not a reviewer though.
Could I also ask you to push this changeset to jdk/client [1] instead of 
jdk/jdk?

A small question: two prototypes are changed in debug_trace.h but only 
one is updated in debug_trace.c. Is it because the functions matching 
the second prototype have already been updated with JNICALL?

Regards,
Alexey

[1] http://hg.openjdk.java.net/jdk/client/

On 25/03/2019 13:09, Thomas Stüfe wrote:
> Hi all,
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8221405
> cr: 
> http://cr.openjdk.java.net/~stuefe/webrevs/8221405-windows32-awt-buildfixes/webrev.00/webrev/
>
> On 32bit windows, awt build did bitrot. Dtrace print callbacks need to 
> be declared with __stdcall. No other platform cares.
>
> Thanks, Thomas



More information about the awt-dev mailing list