<AWT Dev> RFR: 8224632: testbug: java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java fails on MacOS

[Phil Race]

Sure :-


- * @bug 4393148 8136999 8186263
+ * @bug 4393148 8136999 8186263 8224632
   * @summary tests that removal of the drop target or disposal of frame 
during
   *          drop processing doesn't cause crash
- * @run main RemoveDropTargetCrashTest RUN_PROCESS
+ * @run main/timeout=300 RemoveDropTargetCrashTest RUN_PROCESS
   */
  public class RemoveDropTargetCrashTest {

@@ -301,7 +301,7 @@
                  + " " + RemoveDropTargetCrashTest.class.getName() + " 
" + RUN_TEST;

          Process process = Runtime.getRuntime().exec(command);
-        boolean processExit = process.waitFor(100, TimeUnit.SECONDS);
+        boolean processExit = process.waitFor(200, TimeUnit.SECONDS);

-phil.

On 5/23/19 2:22 PM, Sergey Bylokhov wrote:
> Hi, Phil.
>
> I guess the new timeout is bigger than the default timeout in jtreg, 
> and it should be bumped as well?
>
> On 23/05/2019 13:56, Phil Race wrote:
>>
>> On onw of our test systems which is somewhat under-powered (an oldish 
>> mac-mini),
>> the child process in this test takes 114 seconds to run (vs 
>> 60-something on my MacBook)
>> So I propose to increase the allowed timeout
>>
>> -phil.
>>
>> bug:  https://bugs.openjdk.java.net/browse/JDK-8224632
>>
>> fix :
>>
>> diff --git 
>> a/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java 
>> b/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java 
>>
>> --- 
>> a/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java
>> +++ 
>> b/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java
>> @@ -60,7 +60,7 @@
>>   /**
>>    * @test
>>    * @key headful
>> - * @bug 4393148 8136999 8186263
>> + * @bug 4393148 8136999 8186263 8224632
>>    * @summary tests that removal of the drop target or disposal of 
>> frame during
>>    *          drop processing doesn't cause crash
>>    * @run main RemoveDropTargetCrashTest RUN_PROCESS
>> @@ -301,7 +301,7 @@
>>                   + " " + RemoveDropTargetCrashTest.class.getName() + 
>> " " + RUN_TEST;
>>
>>           Process process = Runtime.getRuntime().exec(command);
>> -        boolean processExit = process.waitFor(100, TimeUnit.SECONDS);
>> +        boolean processExit = process.waitFor(200, TimeUnit.SECONDS);
>>
>>           StringBuilder inStream = new StringBuilder();
>>           StringBuilder errStream = new StringBuilder();
>>
>
>