<AWT Dev> RFR: 8224632: testbug: java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java fails on MacOS

[Prasanta Sadhukhan]

I guess Sergey told in one of our review that if it is just a test-only 
fix, then there's no need to update the bug entry as per 
http://openjdk.java.net/jtreg/faq.html#when-should-i-update-the-bug-entry-in-a-test-description

so I guess it is not needed here as well, as we need to adopt a same 
approach. Otherwise looks fine.

Regards
Prasanta
On 24-May-19 3:26 AM, Sergey Bylokhov wrote:
> Looks fine.
>
> On 23/05/2019 14:23, Phil Race wrote:
>> Sure :-
>>
>>
>> - * @bug 4393148 8136999 8186263
>> + * @bug 4393148 8136999 8186263 8224632
>>    * @summary tests that removal of the drop target or disposal of 
>> frame during
>>    *          drop processing doesn't cause crash
>> - * @run main RemoveDropTargetCrashTest RUN_PROCESS
>> + * @run main/timeout=300 RemoveDropTargetCrashTest RUN_PROCESS
>>    */
>>   public class RemoveDropTargetCrashTest {
>>
>> @@ -301,7 +301,7 @@
>>                   + " " + RemoveDropTargetCrashTest.class.getName() + 
>> " " + RUN_TEST;
>>
>>           Process process = Runtime.getRuntime().exec(command);
>> -        boolean processExit = process.waitFor(100, TimeUnit.SECONDS);
>> +        boolean processExit = process.waitFor(200, TimeUnit.SECONDS);
>>
>> -phil.
>>
>> On 5/23/19 2:22 PM, Sergey Bylokhov wrote:
>>> Hi, Phil.
>>>
>>> I guess the new timeout is bigger than the default timeout in jtreg, 
>>> and it should be bumped as well?
>>>
>>> On 23/05/2019 13:56, Phil Race wrote:
>>>>
>>>> On onw of our test systems which is somewhat under-powered (an 
>>>> oldish mac-mini),
>>>> the child process in this test takes 114 seconds to run (vs 
>>>> 60-something on my MacBook)
>>>> So I propose to increase the allowed timeout
>>>>
>>>> -phil.
>>>>
>>>> bug:  https://bugs.openjdk.java.net/browse/JDK-8224632
>>>>
>>>> fix :
>>>>
>>>> diff --git 
>>>> a/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java 
>>>> b/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java 
>>>>
>>>> --- 
>>>> a/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java
>>>> +++ 
>>>> b/test/jdk/java/awt/dnd/RemoveDropTargetCrashTest/RemoveDropTargetCrashTest.java
>>>> @@ -60,7 +60,7 @@
>>>>   /**
>>>>    * @test
>>>>    * @key headful
>>>> - * @bug 4393148 8136999 8186263
>>>> + * @bug 4393148 8136999 8186263 8224632
>>>>    * @summary tests that removal of the drop target or disposal of 
>>>> frame during
>>>>    *          drop processing doesn't cause crash
>>>>    * @run main RemoveDropTargetCrashTest RUN_PROCESS
>>>> @@ -301,7 +301,7 @@
>>>>                   + " " + RemoveDropTargetCrashTest.class.getName() 
>>>> + " " + RUN_TEST;
>>>>
>>>>           Process process = Runtime.getRuntime().exec(command);
>>>> -        boolean processExit = process.waitFor(100, TimeUnit.SECONDS);
>>>> +        boolean processExit = process.waitFor(200, TimeUnit.SECONDS);
>>>>
>>>>           StringBuilder inStream = new StringBuilder();
>>>>           StringBuilder errStream = new StringBuilder();
>>>>
>>>
>>>
>>
>
>