<AWT Dev> RFR: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

[Sergey Bylokhov]

Hi, Matthias.

On 10/22/19 1:06 am, Baesken, Matthias wrote:
> It is the combination of running  the tests with  ea/esa  AND   our strange setup  ;
>   the assertion occurred when handling in the isDirectory - method of Win32ShellFolder2 a  ShellFolder with display name "The Internet" which has attribute ATTRIB_BROWSABLE but not ATTRIB_FOLDER set.

Do you know the steps on how to create such "The Internet" link?

> 
> 
> And  I am not  even 100% sure that the assertion we see  is correct in this case.
> 
> Best regards, Matthias
> 
> 
> 
>> Hi Matthias,
>>
>> We also run the tests using -ea/-esa parameters but I do not remember
>> that we get such assertions if you found them then you a lucky because
>> our assertion found the bug in the implementation, I do not think to
>> hide the problem is a right thing to do.
>>
>> On 10/18/19 5:37 am, Baesken, Matthias wrote:
>>> at
>> java.desktop/sun.awt.shell.Win32ShellFolder2$4.call(Win32ShellFolder2.java
>> :438)
>>>
>>> So I think it is  probably the best to disable assertions for the test
>> because  the combination  -ea/-esa   +  strange Shellfolder setup is not seen
>> very often .
>>>
>>> Bug/webrev :
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8227257
>>>
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8227257.0/
>>>
>>> Thanks, Matthias
>>>
>>
>>
>> --
>> Best regards, Sergey.


-- 
Best regards, Sergey.