<AWT Dev> [14] RFR JDK-8233703:java/awt/Frame/FrameLocation.java fails on mac

[Prasanta Sadhukhan]

On 06-Nov-19 7:50 PM, Prasanta Sadhukhan wrote:
>
> Hi Dmitry,
>
> Why do you think the problem is not in the test? I guess this exact 
> issue of incorrect frame location is fixed by JDK-6895647 
> <https://bugs.openjdk.java.net/browse/JDK-6895647> in linux and the 
> fix still is there in XDecoratedPeer.java.
>
Also, the test pass always in local ubuntu18.04 system that I have. it 
only fails on mach5 linux system (that too not every time) which makes 
me think it's a test issue.
> Regards
> Prasanta
> On 06-Nov-19 7:13 PM, Dmitry Markov wrote:
>> Hi Prasanta,
>>
>> If I got it right, we might not have enough time to show frame on the screen without sleep() invocation. As a result incorrect frame location will be retrieved. So I think we should NOT get rid of sleep() call here.
>>
>> Also it appears that the problem is not in the test at all.
>>
>> Thanks,
>> Dmitry
>>
>>> On 6 Nov 2019, at 13:09, Prasanta Sadhukhan<prasanta.sadhukhan at oracle.com>  wrote:
>>>
>>> Actually the failure is on linux. I have updated the JBS summary.
>>>
>>> On 06-Nov-19 5:27 PM, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>>
>>>> Please review a fix for an issue where it is seen the frame location is sometimes wrong in mac on mach5 headful nightly run.
>>>>
>>>> It seems to be a timing issue as it shows 10 frames by calling frame.removeNotify(),frame.addNotify() repeatedly, which by the way are not supposed to be called by programs directly.
>>>>
>>>> Proposed fix is to make not to make thread sleep every time removeNotify,addNotify is called so that there is no delay. I have ran mach5 job (in JBS) for 3 consecutive runs on all 3 platforms and they pass.
>>>>
>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8233703
>>>>
>>>> webrev:http://cr.openjdk.java.net/~psadhukhan/8233703/webrev.0/
>>>>
>>>> Regards
>>>> Prasanta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20191106/21fb1f90/attachment.html>